Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace drag handle icons #879

Merged
merged 9 commits into from
Jun 11, 2022

Conversation

dw-0
Copy link
Member

@dw-0 dw-0 commented Jun 10, 2022

This PR currently includes:

  • replace old drag handles with proper dragging icons
    • GcodefilesPanel.vue, SettingsMacroTabExpert, SettingsDashboardTab (multiple)
  • always show drag handles
  • truncate text if viewport too narrow
  • bugfix: it was possible to toogle viewports on and off
  • cursor style becomes "move" on hover over drag handle

Screenshots:

image
image
image

Signed-off-by: Dominik Willner [email protected]

- replace old drag handles with proper dragging icons
- always show drag handles
- truncate text if viewport too narrow

Signed-off-by: Dominik Willner <[email protected]>
@dw-0 dw-0 added this to the vNext milestone Jun 10, 2022
@dw-0 dw-0 linked an issue Jun 10, 2022 that may be closed by this pull request
@dw-0 dw-0 removed this from the vNext milestone Jun 10, 2022
@dw-0 dw-0 changed the title refactor: improve dashboard settings refactor: replace drag handle icons Jun 10, 2022
@dw-0 dw-0 marked this pull request as ready for review June 10, 2022 20:50
@dw-0 dw-0 requested a review from meteyou June 10, 2022 20:50
@meteyou meteyou merged commit a6c09bc into mainsail-crew:develop Jun 11, 2022
@dw-0 dw-0 deleted the settings-dashboard-improvements branch June 11, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] improvements on the dashboard settings tab
2 participants